fix: remove extras from all adhoc_filters controls #21450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21450 +/- ##
=======================================
Coverage 66.53% 66.54%
=======================================
Files 1791 1791
Lines 68599 68602 +3
Branches 7320 7320
=======================================
+ Hits 45645 45648 +3
Misses 21064 21064
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
force-pushed
the
villebro/fix-remove-adhoc-extras
branch
from
ffdad8c
to
978519f
Compare
zhaoyongjie
approved these changes
Sep 13, 2022
3 tasks
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 20, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com> (cherry picked from commit e1e9fda)
3 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When setting native or filter box filters in a dashboard and then exploring a Mixed Timeseries chart and then saving the chart, the extra filters are only removed from the first query. This PR changes the removal logic so that all controls that start with the text
adhoc_filtersare cleaned from extra filters before saving. The logic is added both to the deprecated backend logic (set for removal in 3.0) and the new frontend logic which cleans the extra adhoc filters before sending the request to the v1 chart API.AFTER
With this fix the extra filters are removed from the second query of the mixed chart (notice there are no extra filters in the adhoc filter control):
BEFORE
Previously saving the mixed chart with an extra filter would persist the extra filters in the chart metadata:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION